Skip to content

gh-151126: Fix missing memory errors in _interpchannelsmodule.c#151239

Merged
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-151126-_interpchannelsmodule
Jun 10, 2026
Merged

gh-151126: Fix missing memory errors in _interpchannelsmodule.c#151239
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-151126-_interpchannelsmodule

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2026
Open
@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 10, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jun 10, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Mixed approach is used in this file -- some function don't raise an exception, but return an error code (negative, not -1) which then will be converted to exception in handle_channel_error(). Changes in this PR look good, but please check all other returns returning NULL or -1. There may be other bugs in this file.

@sobolevn

sobolevn commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Sure! I will check other things as well and report them in a separate issue. Thanks a lot for the review!

@sobolevn sobolevn merged commit 9fd1a12 into python:main Jun 10, 2026
64 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9fd1a125bc0ebdc26eae684da6e48ef24ee23b34 3.14

@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151265 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 10, 2026
@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151266 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 10, 2026
sobolevn added a commit that referenced this pull request Jun 10, 2026
@miss-islington @sobolevn
[3.15] gh-151126: Fix missing memory errors in `_interpchannelsmodule…
54ee910 
….c` (GH-151239) (#151265)

gh-151126: Fix missing memory errors in `_interpchannelsmodule.c` (GH-151239)
(cherry picked from commit 9fd1a12)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@sobolevn sobolevn

Labels

awaiting merge needs backport to 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @serhiy-storchaka