Many places have missing `PyErr_NoMemory()` call after failing memory allocation

[sobolevn]

Crash report

1. remove_unused_consts in Python/flowgraph.c

When PyMem_Malloc(nconsts * sizeof(Py_ssize_t)); fails, we need to set an exception.

cpython/Python/flowgraph.c

Lines 3267 to 3283 in 29a920e

	static int
	remove_unused_consts(basicblock *entryblock, PyObject *consts)
	{
	assert(PyList_CheckExact(consts));
	Py_ssize_t nconsts = PyList_GET_SIZE(consts);
	if (nconsts == 0) {
	return SUCCESS; /* nothing to do */
	}
	Py_ssize_t *index_map = NULL;
	Py_ssize_t *reverse_index_map = NULL;
	int err = ERROR;
	index_map = PyMem_Malloc(nconsts * sizeof(Py_ssize_t));
	if (index_map == NULL) {
	goto end;
	}

2. gethandlelist and getattributelist in _winapi.c

This place misses it:

cpython/Modules/_winapi.c

Lines 1196 to 1198 in 9fdbade

	ret = PyMem_Malloc(*size);
	if (ret == NULL)
	goto cleanup;

All other error paths set exceptions, except this if:

cpython/Modules/_winapi.c

Lines 1278 to 1282 in 9fdbade

	attribute_list->attribute_list = PyMem_Malloc(attribute_list_size);
	if (attribute_list->attribute_list == NULL) {
	ret = -1;
	goto cleanup;
	}

3. _channelends_new in Modules/_interpchannelsmodule.c

cpython/Modules/_interpchannelsmodule.c

Lines 920 to 926 in 3ca93ab

	static _channelends *
	_channelends_new(void)
	{
	_channelends *ends = GLOBAL_MALLOC(_channelends);
	if (ends== NULL) {
	return NULL;
	}

Later we check for errors in handle_channel_error, it requires either setting err to non -1 or to set Python exception. Both are false, it fails with the assertion failure.

Linked PRs

• gh-151126: Fix missing PyErr_NoMemory() in remove_unused_consts #151127
• [3.15] gh-151126: Fix missing PyErr_NoMemory() in remove_unused_consts (GH-151127) #151134
• [3.14] gh-151126: Fix missing PyErr_NoMemory() in remove_unused_consts (GH-151127) #151135
• [3.13] gh-151126: Fix missing PyErr_NoMemory() in remove_unused_consts (GH-151127) #151136
• gh-151126: Add PyErr_NoMemory() in strong_cache_node_new #151137
• gh-151126: Add missing PyErr_NoMemory in _winapi module #151154
• [3.15] gh-151126: Add missing PyErr_NoMemory in _winapi module (GH-151154) #151180
• [3.14] gh-151126: Add missing PyErr_NoMemory in _winapi module (GH-151154) #151181
• [3.13] gh-151126: Add missing PyErr_NoMemory in _winapi module (GH-151154) #151182
• gh-151126: Fix missing memory errors in _interpchannelsmodule.c #151239
• [3.15] gh-151126: Fix missing memory errors in _interpchannelsmodule.c (GH-151239) #151265
• [3.13] gh-151126: Fix missing memory errors in _interpchannelsmodule.c (GH-151239) #151266

[sobolevn]

Well, actually a lot of places have the same problem. I will turn this issue into a meta one and will 1 PR per module, so it would be easier to review / backport.

[serhiy-storchaka]

This is probably a new code. Such errors were fixed in old code years ago.