Add PEP 712 converters to the dataclasses spec#1783
Merged
Conversation
Closed
5 tasks
carljm
reviewed
Jun 21, 2024
Thanks Carl! Co-authored-by: Carl Meyer <carl@oddbird.net>
rchen152
reviewed
Jun 22, 2024
erictraut
requested changes
Jun 23, 2024
thejcannon
commented
Jun 25, 2024
carljm
requested changes
Jun 26, 2024
Hnasar
reviewed
Jul 1, 2024
rchen152
approved these changes
Jul 2, 2024
carljm
approved these changes
Jul 12, 2024
carljm
left a comment
Member
There was a problem hiding this comment.
One wording nit comment, but the substance of this change looks good to me. Thanks for your work on this!
JelleZijlstra
approved these changes
Jul 13, 2024
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Looks good, one nitpick.
Contributor
Author
🫡 This is a high point in my career 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up from https://discuss.python.org/t/would-adding-converter-to-dataclass-transform-even-need-a-pep/55125
Which stems from https://discuss.python.org/t/pep-712-adding-a-converter-parameter-to-dataclasses-field/26126 (already discussed) this PR adds
converteras another field specifier parameter.