Add 2018#5069
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@m1guelpf Signing the PSF Contributor Agreement is required for contributing to Python. |
|
@the-knights-who-say-ni @duttaditya18 Signed! |
| provided, however, that PSF's License Agreement and PSF's notice of copyright, | ||
| i.e., "Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, | ||
| 2011, 2012, 2013, 2014, 2015, 2016, 2017 Python Software Foundation; All Rights | ||
| 2011, 2012, 2013, 2014, 2015, 2016, 2017 2018 Python Software Foundation; All Rights |
There was a problem hiding this comment.
Missing a comma after 2017 and it looks like "Rights" should flow to the next line to maintain consistent wrapping.
| provided, however, that PSF's License Agreement and PSF's notice of copyright, | ||
| i.e., "Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, | ||
| 2011, 2012, 2013, 2014, 2015, 2016, 2017 Python Software Foundation; All Rights | ||
| 2011, 2012, 2013, 2014, 2015, 2016, 2017 2018 Python Software Foundation; All Rights |
There was a problem hiding this comment.
missing comma
this addition makes also this line only one that has more than 80 characters (newline characters excluded)
Not sure if this is fine in legal-speak, but chaning it to 2001-2018 would make this thing much less of a hassle to maintain and read.
|
@m1guelpf I would suggest you to squash the commits. And also update the dates in |
|
@duttaditya18 Pull Request is squashed on merging anyway. |
|
@asvetlov Oh yeah! Forgot that! |
|
@duttaditya18 Done! |
|
@m1guelpf Awesome!! |
|
@m1guelpf Awesome! Now wait for the merger! |
|
Done by @benjaminp in #5094 #5104 #5105 |
|
@m1guelpf Dang dude! Couldn't get your contribution to Python. Keep trying though. |
TO DO: