gh-151436: Fix missing tstate->last_profiled_frame updates#151437
Open
maurycy wants to merge 2 commits into
Open
gh-151436: Fix missing tstate->last_profiled_frame updates#151437maurycy wants to merge 2 commits into
tstate->last_profiled_frame updates#151437maurycy wants to merge 2 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #151436 for more details.
The issue is fixed,
drv_ais back:0,5% (48/9996 = 0,48%) is roughly correct, since it shouldn't be exactly linear.
I can try to come up with reproduction for each miss.
Should it be a helper?
If you ask me, the whole mechanism smells me of ABA...
_remote_debugging: Missinglast_profiled_frameupdates in coroutines, generators, etc. #151436