gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246
Merged
Conversation
… evaluation fails
Contributor
Author
|
@serhiy-storchaka Could you please help review this PR? Thank you very much! |
|
Thanks @Wulian233 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2026
…sion failure (pythonGH-146246) (cherry picked from commit 9343518) Co-authored-by: Wulian233 <1055917385@qq.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2026
…sion failure (pythonGH-146246) (cherry picked from commit 9343518) Co-authored-by: Wulian233 <1055917385@qq.com>
|
GH-146432 is a backport of this pull request to the 3.14 branch. |
|
GH-146433 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Mar 27, 2026
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SET_ITEMmacro leaks dict on expression failure #146244