Skip to content

gh-138850: Add --disable-epoll to configure#145768

Merged
encukou merged 5 commits into
python:mainfrom
mtelka:disable-epoll
Mar 30, 2026
Merged

gh-138850: Add --disable-epoll to configure#145768
encukou merged 5 commits into
python:mainfrom
mtelka:disable-epoll

Conversation

@mtelka

@mtelka mtelka commented Mar 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app

bedevere-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot

python-cla-bot Bot commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2026
Closed
@encukou

encukou commented Mar 25, 2026

Copy link
Copy Markdown
Member

Looks good! Could you also add docs to https://docs.python.org/3/using/configure.html (maybe a new System Options?) and to https://docs.python.org/3/library/select.html#select.epoll?

Or let me know if you want me to do that.

@mtelka

mtelka commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@encukou I'd really appreciate if you'll do that. Thank you.

@vstinner

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member

@mtelka: Would it make sense to detect illumos in configure and disable epoll support on this OS?

@mtelka

mtelka commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

@mtelka: Would it make sense to detect illumos in configure and disable epoll support on this OS?

Yes, it would. However I'm not sure it is worth doing.

@vstinner

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member

I tested the change on Linux:

$ ./configure --disable-epoll && make
$ ./python
>>> import select
>>> select.epoll
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    select.epoll
AttributeError: module 'select' has no attribute 'epoll'. Did you mean '.poll' instead of '.epoll'?

It works as expected :-)

vstinner
vstinner approved these changes Mar 27, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@encukou encukou merged commit 7b2495e into python:main Mar 30, 2026
52 checks passed
@mtelka mtelka deleted the disable-epoll branch March 30, 2026 16:42
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 30, 2026
@maurycy
Merge remote-tracking branch 'upstream/main' into tachyon-ndjson-kole…
6a0ea81 
…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@mtelka @encukou @clin1234
pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
9d5d83f 
* pythongh-138850: Add --disable-epoll to configure


Co-authored-by: Petr Viktorin <encukou@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@mtelka @encukou @ljfp
pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
be02cfc 
* pythongh-138850: Add --disable-epoll to configure


Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

configure option for epoll disable

3 participants

@mtelka @encukou @vstinner