Skip to content

gh-134584: Remove redundant refcount from _BINARY_OP_ADD_UNICODE#142825

Merged
corona10 merged 5 commits into
python:mainfrom
corona10:gh-134584-x-unicode
Dec 18, 2025
Merged

gh-134584: Remove redundant refcount from _BINARY_OP_ADD_UNICODE#142825
corona10 merged 5 commits into
python:mainfrom
corona10:gh-134584-x-unicode

Conversation

@corona10

@corona10 corona10 commented Dec 16, 2025

Copy link
Copy Markdown
Member

@corona10

corona10 commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

@Fidget-Spinner I am working on _BINARY_OP_INPLACE_ADD_UNICODE too, but there were several issues with _POP_TOP_UNICODE in local, I am going to dig separately.

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments. thanks!

Comment thread Python/bytecodes.c Outdated
Comment thread Python/bytecodes.c Outdated
Comment thread Python/bytecodes.c

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Let's wait a day before merging!

@corona10 corona10 merged commit 71a7cb8 into python:main Dec 18, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants