Skip to content

gh-138360: Fix test_free_threading for IO objects#138359

Merged
sobolevn merged 1 commit into
python:mainfrom
uhx:patch-2
Sep 1, 2025
Merged

gh-138360: Fix test_free_threading for IO objects#138359
sobolevn merged 1 commit into
python:mainfrom
uhx:patch-2

Conversation

@uhx

@uhx uhx commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

@python-cla-bot

python-cla-bot Bot commented Sep 1, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 1, 2025
@bedevere-app

bedevere-app Bot commented Sep 1, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@uhx

uhx commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

@Eclips4 please add skip-news label & review

@picnixz picnixz changed the title Fix typo in test_io.py Fix test_free_threading for IO objects Sep 1, 2025
@picnixz

picnixz commented Sep 1, 2025

Copy link
Copy Markdown
Member

I think it would make sense to have an issue, just for backports tracking. I'll create one.

@picnixz picnixz changed the title Fix test_free_threading for IO objects gh-138360: Fix test_free_threading for IO objects Sep 1, 2025
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 1, 2025
@uhx

uhx commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz thanks a lot

@Eclips4

Eclips4 commented Sep 1, 2025

Copy link
Copy Markdown
Member

@picnixz I don't think that we need any test case here. What do you think?

@sobolevn sobolevn enabled auto-merge (squash) September 1, 2025 19:37
@picnixz

picnixz commented Sep 1, 2025

Copy link
Copy Markdown
Member

I don't think that we need any test case here. What do you think?

Err, no? this PR is fine!

@sobolevn sobolevn merged commit 7c92497 into python:main Sep 1, 2025
57 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @uhx for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @uhx and @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c92497e5c6d3d6c36721f554d09efffbe4bbc23 3.14

@miss-islington-app

Copy link
Copy Markdown

Sorry, @uhx and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c92497e5c6d3d6c36721f554d09efffbe4bbc23 3.13

@picnixz

picnixz commented Sep 2, 2025

Copy link
Copy Markdown
Member

@uhx Could you take care of the backports please? you'll need to find the tests (they could have moved somewhere else)

@uhx

uhx commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz sure thing, I took a quick look at it yesterday but didn't find anything.

I checked the PR that introduced this test and noticed that this change was not included into 3.14:

I also couldn't find these changes in any of the versions (3.13, 3.14)

@picnixz

picnixz commented Sep 2, 2025

Copy link
Copy Markdown
Member

Oh so they were only 3.15+, no need for backports for now! Thank for having a look. However, I think #132616 should have been backported as it's a bugfix IMO.

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@hugovk hugovk removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants