Skip to content

gh-120713: Make _Py_NORMALIZE_CENTURY private#135933

Merged
encukou merged 7 commits into
python:mainfrom
encukou:private-Py_NORMALIZE_CENTURY
Jul 7, 2025
Merged

gh-120713: Make _Py_NORMALIZE_CENTURY private#135933
encukou merged 7 commits into
python:mainfrom
encukou:private-Py_NORMALIZE_CENTURY

Conversation

@encukou

@encukou encukou commented Jun 25, 2025

Copy link
Copy Markdown
Member

Users don't need this macro, and we don't want to document & support it. Right?

(We're not very consistent with configure macros, but we can start making things better with ones added in 3.14.)

@encukou encukou mentioned this pull request Jun 26, 2025
39 tasks
@serhiy-storchaka

serhiy-storchaka commented Jun 26, 2025

Copy link
Copy Markdown
Member

See also other approach in #128444 which allows to get rid of that macro.

@encukou encukou added the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukou

encukou commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Do you intend to backport #128444 to 3.14?

@serhiy-storchaka

Copy link
Copy Markdown
Member

If it is reviewed and accepted. I do not risk to merge it without review.

@encukou

encukou commented Jul 7, 2025

Copy link
Copy Markdown
Member Author

I'll merge this, and update the other PR(s) to remove the private macro.

@encukou encukou merged commit fb170cf into python:main Jul 7, 2025
39 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@encukou encukou deleted the private-Py_NORMALIZE_CENTURY branch July 7, 2025 15:57
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
(cherry picked from commit fb170cf)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136387 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 8, 2025
…6387)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants