Skip to content

gh-132435: Test syntax warnings in a finally block#132436

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
tomasr8:finally-warning
Apr 13, 2025
Merged

gh-132435: Test syntax warnings in a finally block#132436
serhiy-storchaka merged 4 commits into
python:mainfrom
tomasr8:finally-warning

Conversation

@tomasr8

@tomasr8 tomasr8 commented Apr 12, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2025
Closed
@tomasr8 tomasr8 mentioned this pull request Apr 12, 2025
Merged
serhiy-storchaka
serhiy-storchaka reviewed Apr 12, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Eclips4
Eclips4 approved these changes Apr 12, 2025
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sobolevn
sobolevn reviewed Apr 12, 2025
View reviewed changes
Comment thread Lib/test/test_compile.py
@tomasr8 tomasr8 requested a review from sobolevn April 12, 2025 21:27
@sobolevn

sobolevn commented Apr 12, 2025

Copy link
Copy Markdown
Member

Do we need to backport this?

@sobolevn sobolevn enabled auto-merge (squash) April 12, 2025 21:30
@tomasr8

tomasr8 commented Apr 12, 2025

Copy link
Copy Markdown
Member Author

I would, once #131993 is backported as well.

@Eclips4

Eclips4 commented Apr 13, 2025

Copy link
Copy Markdown
Member

CI seems stuck. Merging main to restart it.

@tomasr8

tomasr8 commented Apr 13, 2025

Copy link
Copy Markdown
Member Author

The multiprocessing test failures (ENV_CHANGED) do not seem related. I've also seen them fail on other PRs recently

@serhiy-storchaka

serhiy-storchaka commented Apr 13, 2025

Copy link
Copy Markdown
Member

While we are here, please add a NEWS entry about emitting compiler warnings twice. This is a user visible change, and can save a day for somebody.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) April 13, 2025 08:38
@tomasr8 tomasr8 added the needs backport to 3.13 bugs and security fixes label Apr 13, 2025
@serhiy-storchaka serhiy-storchaka merged commit 887eabc into python:main Apr 13, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 13, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Apr 13, 2025

Copy link
Copy Markdown

Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 887eabc5a74316708460120d60d0fa4f8bdf5960 3.13

@tomasr8 tomasr8 deleted the finally-warning branch April 13, 2025 20:51
@tomasr8

tomasr8 commented Apr 13, 2025

Copy link
Copy Markdown
Member Author

I can backport this tomorrow, unless you beat me to it

@serhiy-storchaka

serhiy-storchaka commented Apr 13, 2025

Copy link
Copy Markdown
Member

It is a midnight here, so I'll be AFK for next 9-10 hours.

@bedevere-app

bedevere-app Bot commented Apr 14, 2025

Copy link
Copy Markdown

GH-132503 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
serhiy-storchaka pushed a commit that referenced this pull request Apr 14, 2025
@tomasr8
[3.13] gh-132435: Test syntax warnings in a finally block (GH-132436) (…
5f1eaff 
…GH-132503)

(cherry picked from commit 887eabc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@sobolevn sobolevn sobolevn approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomasr8 @sobolevn @Eclips4 @serhiy-storchaka