gh-62480: Remove first-person usage for some docs#102295
Closed
nw0 wants to merge 1 commit into
Closed
Conversation
Additionally: clean up the text explanation for one mock example which this commit touches.
bumper-furkan-onder
approved these changes
Mar 7, 2023
furkanonder
approved these changes
Mar 7, 2023
hauntsaninja
requested changes
Nov 14, 2024
hauntsaninja
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure this is an improvement. It also introduces a typo
Contributor
|
Hey @nw0, do you mind if I pick this up? 🙂 Except if @hauntsaninja thinks it should be closed? |
Contributor
Author
Please do. I'm going to close this PR, as it's not had meaningful feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally: clean up the text explanation for one mock example which this commit touches.
In particular I think this addresses the remaining examples in #62480 (comment)