Added python 3 support and cleaned up some testing files#22
Added python 3 support and cleaned up some testing files#22Henry R (henryrizzi) wants to merge 5 commits into
Conversation
| self._token['verifier'] = parse_qs(response.content)['oauth_verifier'][0] | ||
|
|
||
| self._token['verifier'] = parse_qs(response.text)['oauth_verifier'][0] | ||
…exts and removed trailing whitespace in __init__.py
|
The trailing whitespace has been purged from init.py The client.py tests won't all run right now, but the delete test is still failing on master. On python 2.6, a few tests will fail because of differences in the way that failUnlessRaises works in different versions, but the actual api should still function. |
| ox3apiclient.egg-info/ | ||
| landing/* | ||
| build/* | ||
| dist/* |
There was a problem hiding this comment.
these folders look specific to your environment. Maybe you want to change your ~/.gitignore instead.
|
I just removed those folders from my .gitignore. the egg-info is jut the file generated in python3 when you run |
|
How stable is this branch for production? It looks a lot cleaner than the requests_oauthlib branch i'm currently using. |
|
I've used it to get a lot of reports, but so far haven't had to do anything with deleting, posting or putting. For getting reports at least, it is very stable and I haven't run into any issues so far on python 3.5.2 |
|
I use it mainly to create and delete objects in API. requests_oauthlib is merged into this branch and some bugs are fixed. |
|
Has anyone else tested this for their use case using python 3? |
|
Superseded by #33 |
I changed the library to use
response.textrather thanresponse.contentas this will allow the text to be automatically decoded in both python 2.6+ and python 3. Also, the six library is used to bridge the gap between python 2 and 3.