Skip to content

tls: fix minor jslint failure for v0.10#9107

Closed
rvagg wants to merge 1 commit into
nodejs:v0.10-stagingfrom
rvagg:jslint-fix-0.10
Closed

tls: fix minor jslint failure for v0.10#9107
rvagg wants to merge 1 commit into
nodejs:v0.10-stagingfrom
rvagg:jslint-fix-0.10

Conversation

@rvagg

@rvagg rvagg commented Oct 15, 2016

Copy link
Copy Markdown
Member

Really minor but it passes make jslint on v0.10, we broke it backporting the TLS wildcard checking vulnerability in the last release @ 0d7e21e. As long as we're doing another release we may as well clean up!

@nodejs-github-bot nodejs-github-bot added tls Issues and PRs related to the tls subsystem. v0.10 labels Oct 15, 2016

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibfahn

gibfahn commented Oct 15, 2016

Copy link
Copy Markdown
Member

@rvagg Are we definitely doing another release of v0.10?

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg

rvagg commented Oct 18, 2016

Copy link
Copy Markdown
Member Author

@gibfahn yeah, the c-ares fix is relatively important, #9108, please review that one if you can

rvagg added a commit that referenced this pull request Oct 18, 2016
PR-URL: #9107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@rvagg

rvagg commented Oct 18, 2016

Copy link
Copy Markdown
Member Author

landed @ b798f59

@rvagg rvagg closed this Oct 18, 2016
rvagg added a commit that referenced this pull request Oct 18, 2016
PR-URL: #9107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg added a commit that referenced this pull request Oct 18, 2016
PR-URL: #9107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
PR-URL: nodejs/node#9107
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants