Skip to content

doc: update authors list again#8346

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:update-authors-2
Closed

doc: update authors list again#8346
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:update-authors-2

Conversation

@jasnell

@jasnell jasnell commented Aug 30, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Another round of AUTHORS.md updates. This is an initial take. The list needs to be cleaned with duplicates removed and real names added. Help is appreciated! :-) /cc @nodejs/collaborators

Note: All of the edits on this were generated automatically by the update-authors tool. It's quite likely that there are incorrect edits.

@jasnell jasnell added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Aug 30, 2016
Comment thread AUTHORS Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done on a purpose?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope... the update-authors tool changed a bunch of these. I'm changing them back

@rumkin

rumkin commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

@jasnell Rumkin is ok.

@jasnell

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

Ok, @nodejs/collaborators ... I think this is ready to go. PTAL

Comment thread AUTHORS Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, I’m duplicate! 😄 (this one is the one which should be removed)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! I thought I caught all of those. thanks! :-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@addaleax

addaleax commented Sep 2, 2016

Copy link
Copy Markdown
Member

LGTM! :)

@silverwind

silverwind commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

@jasnell why not edit .mailmap so you don't have to do the same manual changes the next time?

@jasnell

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

heh... that would make far too much sense ;-) ... good idea!

@jasnell

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

@ChALkeR ... does this LGTY?
@nodejs/collaborators ... anyone else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.