[v8.x] deps: V8: backport d520ebb#27358
Closed
targos wants to merge 1 commit into
Closed
Conversation
Original commit message:
[turbofan] Fix NumberFloor typing.
Bug: chromium:841117
Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
Reviewed-on: https://chromium-review.googlesource.com/1051228
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#53083}
Refs: v8/v8@d520ebb
Fixes: nodejs#22810
Collaborator
Member
Author
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Apr 23, 2019
cjihrig
approved these changes
Apr 23, 2019
refack
approved these changes
Apr 23, 2019
apapirovski
approved these changes
Apr 23, 2019
BethGriggs
approved these changes
May 28, 2019
Collaborator
Member
Author
|
@sam-github why did you close this? |
Contributor
|
@targos I closed it by mistake, sorry! |
Member
Author
|
@nodejs/backporters |
Collaborator
Collaborator
Collaborator
BethGriggs
pushed a commit
that referenced
this pull request
Sep 19, 2019
Original commit message:
[turbofan] Fix NumberFloor typing.
Bug: chromium:841117
Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
Reviewed-on: https://chromium-review.googlesource.com/1051228
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53083}
Refs: v8/v8@d520ebb
Fixes: #22810
PR-URL: #27358
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Member
|
Landed on |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@d520ebb
Fixes: #22810