fix(client): skip unsupported capability requests in ClientSessionGroup#2810
Open
bobby-nandigam wants to merge 3 commits into
Open
fix(client): skip unsupported capability requests in ClientSessionGroup#2810bobby-nandigam wants to merge 3 commits into
bobby-nandigam wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP Python SDK Contribution – Issue #2689
Respect Negotiated Capabilities in ClientSessionGroup
Overview
This contribution improves capability negotiation behavior in the MCP Python SDK.
Previously,
ClientSessionGroup._aggregate_components()attempted to retrieve prompts, resources, and tools from every connected server regardless of the capabilities negotiated during initialization.Problem
During server initialization, MCP servers advertise their supported capabilities. However, the existing implementation attempted to call:
list_prompts()list_resources()list_tools()without verifying whether those capabilities were available.
Solution
The implementation now checks the negotiated capabilities before requesting server components.
New Behavior
This ensures that
ClientSessionGroupinteracts only with features explicitly supported by the connected server.Testing
Added regression test:
test_client_session_group_skips_unsupported_capabilitiesValidation
Output:
Files Modified
src/mcp/client/session_group.pytests/client/test_session_group.pyBenefits
Related Issue
Fixes #2689
Author
Bobby Nandigam