fix(network): handle non-UTF-8 bytes in post_data without raising#3111
Open
wali-reheman wants to merge 1 commit into
Open
fix(network): handle non-UTF-8 bytes in post_data without raising#3111wali-reheman wants to merge 1 commit into
wali-reheman wants to merge 1 commit into
Conversation
post_data.decode() used strict UTF-8 decoding which raises UnicodeDecodeError when the POST body contains invalid UTF-8 bytes. Use errors='replace' to return a best-effort string, matching the behavior of the JavaScript Playwright API. post_data_buffer remains the binary-safe API. Fixes microsoft#3098
|
@wali-reheman please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post_data.decode() used strict UTF-8 decoding which raises UnicodeDecodeError when the POST body contains invalid UTF-8 bytes. Use errors='replace' to return a best-effort string, matching the JavaScript Playwright API. post_data_buffer remains the binary-safe API.
Fixes #3098