[pull] master from airbnb:master#44
Open
pull[bot] wants to merge 9 commits into
Open
Conversation
Allow comments like: ```js /** * Bla bla bla **/ ```
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
The bad example in section 15.6 (nested ternaries) used double-quoted
string literals ('"bar"', '"baz"'), which contradicts section 6.1 of
this same style guide that requires single quotes.
Also related to issue #3152 which flagged inconsistent style conventions
in code examples across sections.
Fixes the bad example to use single-quoted strings consistently with
the rest of the guide and with the good examples immediately below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )