Skip to content

gh-108494: Document how to add a project in PCbuild/readme.txt#110077

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:doc_pcbuild_add_project
Oct 2, 2023
Merged

gh-108494: Document how to add a project in PCbuild/readme.txt#110077
vstinner merged 2 commits into
python:mainfrom
vstinner:doc_pcbuild_add_project

Conversation

@vstinner

@vstinner vstinner commented Sep 29, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 29, 2023
@vstinner vstinner requested a review from a team as a code owner September 29, 2023 07:33
@bedevere-app bedevere-app Bot mentioned this pull request Sep 29, 2023
Closed
@vstinner

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

cc @zooba @zware

zooba
zooba reviewed Sep 29, 2023
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

We should probably eventually add how to do it by hand, as I think that's how most contributors add them, but having this much here will hopefully convince someone else to write it up.

Comment thread PCbuild/readme.txt Outdated
Comment thread PCbuild/readme.txt
Comment thread PCbuild/readme.txt
@vstinner
Complete the doc
c0a05b4 
Add _testclinic_limited to Tools/msi/test/test_files.wxs
@vstinner

vstinner commented Sep 30, 2023

Copy link
Copy Markdown
Member Author

@zooba: I updated the PR to address your review.

@zooba

zooba commented Oct 2, 2023

Copy link
Copy Markdown
Member

LGTM 👍

@vstinner vstinner merged commit 6387b53 into python:main Oct 2, 2023
@vstinner vstinner deleted the doc_pcbuild_add_project branch October 2, 2023 16:53
@miss-islington

miss-islington commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6387b5313c60c1403785b2245db33372476ac304 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@vstinner @miss-islington
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
8c86557 
…ythonGH-110077)

Add _testclinic_limited to Tools/msi/test/test_files.wxs.
(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Oct 2, 2023

Copy link
Copy Markdown

GH-110230 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 2, 2023
@vstinner

vstinner commented Oct 2, 2023

Copy link
Copy Markdown
Member Author

More doc is always a good think, thanks for the review. I didn't know the parts that you showed me.

@bedevere-app

bedevere-app Bot commented Oct 2, 2023

Copy link
Copy Markdown

GH-110232 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 2, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Oct 2, 2023
@vstinner
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
0948cda 
…ython#110077)

(cherry picked from commit 6387b53)
vstinner added a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@vstinner
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
562dc61 
…ythonGH-110077)

(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 2, 2023
@vstinner
[3.11] gh-108494: Document how to add a project in PCbuild/readme.txt (…
981696e 
…#110077) (#110232)

gh-108494: Document how to add a project in PCbuild/readme.txt (#110077)

(cherry picked from commit 6387b53)
vstinner added a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-108494: Document how to add a project in PCbuild/readme.txt (…
74d0b60 
…GH-110077) (#110230)

gh-108494: Document how to add a project in PCbuild/readme.txt (GH-110077)

(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
6d1fc25 
…ython#110077)

Add _testclinic_limited to Tools/msi/test/test_files.wxs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @zooba @miss-islington