Skip to content

gh-106320: Remove _Py_SwappedOp from the C API#107036

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_swapped_op
Jul 22, 2023
Merged

gh-106320: Remove _Py_SwappedOp from the C API#107036
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_swapped_op

Conversation

@vstinner

@vstinner vstinner commented Jul 22, 2023

Copy link
Copy Markdown
Member

Move _Py_SwappedOp to the internal C API (pycore_object.h).

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if someone is using this API, they can write their utility function.

@vstinner

Copy link
Copy Markdown
Member Author

lgtm, if someone is using this API, they can write their utility function.

If someone uses it, we can consider exposing a public API for that.

Or they can just copy/paste this short array in their code.

Move _Py_SwappedOp to the internal C API (pycore_object.h).
The symbol is still exported since it's part of the stable ABI.
@vstinner vstinner force-pushed the remove_swapped_op branch from 136f64d to 3d30d79 Compare July 22, 2023 14:46
@vstinner

Copy link
Copy Markdown
Member Author

The symbol must still be exported since it's part of the stable ABI.

@vstinner vstinner merged commit 6fbc717 into python:main Jul 22, 2023
@vstinner vstinner deleted the remove_swapped_op branch July 22, 2023 16:21
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
Move _Py_SwappedOp to the internal C API (pycore_object.h).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants