Skip to content

GH-104898: Add __slots__ to os.PathLike#104899

Merged
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-104898-add-os-pathlike-slots
May 25, 2023
Merged

GH-104898: Add __slots__ to os.PathLike#104899
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-104898-add-os-pathlike-slots

Conversation

@barneygale

@barneygale barneygale commented May 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
@barneygale barneygale mentioned this pull request May 24, 2023
Closed
@barneygale barneygale requested a review from brettcannon May 24, 2023 21:55
brettcannon
brettcannon approved these changes May 25, 2023
View reviewed changes
Comment thread Lib/test/test_os.py
@barneygale barneygale merged commit bd1b622 into python:main May 25, 2023
@barneygale

barneygale commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @brettcannon! Do you think this should be backported?

@merwok

merwok commented May 25, 2023

Copy link
Copy Markdown
Member

It’s not clearly a bugfix, so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barneygale @merwok @brettcannon @bedevere-bot