http2: add diagnostics channels for client stream request body#60480
Merged
RaisinTen merged 1 commit intoNov 1, 2025
Conversation
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60480 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.02%
==========================================
Files 704 704
Lines 207774 207873 +99
Branches 40027 40063 +36
==========================================
+ Hits 184020 184153 +133
+ Misses 15800 15761 -39
- Partials 7954 7959 +5
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
IlyasShabi
reviewed
Oct 29, 2025
Qard
reviewed
Oct 31, 2025
Member
Qard
left a comment
There was a problem hiding this comment.
Just one concern about this breaking API surface, but otherwise LGTM.
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Nov 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
These would allow inspection of HTTP/2 client stream request bodies. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#60480 Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
be4f77d to
f46152f
Compare
Member
Author
|
Landed in f46152f |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These would allow inspection of HTTP/2 client stream request bodies.
This is needed for #60483.