http: symbol naming convention#29091
Closed
ronag wants to merge 1 commit into
Closed
Conversation
legendecas
reviewed
Aug 12, 2019
legendecas
left a comment
Member
There was a problem hiding this comment.
Is there any written rules for naming a variable of various types?
Member
Author
|
@legendecas: Not that I'm aware of. But it's the convention used in the rest of the code. |
566f9aa to
945b126
Compare
Member
Author
|
@Trott: flaky test? |
Collaborator
lpinca
approved these changes
Aug 12, 2019
Collaborator
945b126 to
0bdebc9
Compare
Collaborator
Collaborator
addaleax
approved these changes
Aug 12, 2019
jasnell
approved these changes
Aug 13, 2019
Trott
approved these changes
Aug 14, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2019
PR-URL: nodejs#29091 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in d303548 |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29091 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the naming convention for symbols.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes