lib: replace var with let#28081
Closed
mbj36 wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Jun 5, 2019
himself65
requested changes
Jun 6, 2019
Member
There was a problem hiding this comment.
there still have many var left.
is this change necessary?
see: https://github.com/nodejs/node/search?utf8=✓&q=for+(var&type=
Member
Member
|
thanks. I get it |
trivikr
approved these changes
Jun 6, 2019
Trott
approved these changes
Jun 6, 2019
antsmartian
approved these changes
Jun 7, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Jun 10, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
This can be done by whoever lands this, but the commit message should probably be more specific. It currently makes it sound like this applies to all instances in |
BridgeAR
approved these changes
Jul 5, 2019
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
Landed in 863402e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
PR-URL: nodejs#28081 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28081 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist