crypto: add sync methods, deprecate optional callbacks by jonathanong · Pull Request #189 · nodejs/node

jonathanong · 2014-12-21T07:26:23Z

See #5

would you like me to add/change tests?
didn't bother disallowing callbacks in the sync version. after all this is about the public API. is that something you guys want?
want doc updates?
only changed .randomBytes() and .pseudoRandomBytes(). were there others?

piscisaureus · 2015-01-10T22:46:16Z

I like this. @iojs/tc

trevnorris · 2015-01-13T00:55:16Z

+1

ruimarinho · 2015-01-13T00:59:50Z

Someone mentioned on another issue (I can't find right now) that we should consider aligning our crypto API with the WebCryptoAPI, specifically using getRandomValues. I think it was an excellent idea. Would this be the moment to consider it?

trevnorris · 2015-01-13T01:02:24Z

@ruimarinho Since 1.0.0-alpha is pushing for release, not right now. Though if there's not an official issue open asking for it then the issue should be created.

piscisaureus · 2015-01-13T03:18:55Z

@jonathanong

only changed .randomBytes() and .pseudoRandomBytes(). were there others?

Yes, crypto.pbkdf2
Edit: I'm actually no so sure the callback is optional there.

charmander · 2015-01-14T17:47:16Z

“Please us” → “Please use” for these last two messages.

jonathanong · 2015-01-23T23:55:03Z

what's the status on this? if desired, i can rebase and reopen for v1.x

brendanashworth · 2015-01-27T06:13:52Z

I'm pretty sure doc updates would be a necessity to merge this in, but I don't believe a rebase and reopen is necessary, as a contributor would merge it manually anyways (unless there are merge conflicts). I could be corrected on that.

…s#186) (nodejs#189) * Fix test-http-server-keepalive-req-gc * Format --------- Co-authored-by: Etienne Pierre-Doray <etipdoray@gmail.com> Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>

crypto: add sync methods, deprecate optional callbacks

d731703

piscisaureus closed this Dec 30, 2014

piscisaureus reopened this Dec 30, 2014

charmander reviewed Jan 14, 2015
View reviewed changes

Comment thread lib/crypto.js

charmander Jan 14, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Please us” → “Please use” for these last two messages.

jonathanong mentioned this pull request Jan 28, 2015

crypto: add sync methods, deprecate optional callbacks #632

Closed

1 task

jonathanong closed this Jan 28, 2015

snyk-bot mentioned this pull request Jan 8, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 timscharfenort/node#5

Open

snyk-bot mentioned this pull request Jul 5, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 sitedata/node#3

Open

snyk-bot mentioned this pull request Aug 11, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 radiumrasheed/node#3

Open

snyk-bot mentioned this pull request Aug 27, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 aliceUnhinged613/node#5

Open

snyk-bot mentioned this pull request Jan 10, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ryan-ally/node#9

Merged

trongham mentioned this pull request Feb 25, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 trongham/node#9

Open

snyk-bot mentioned this pull request Jun 28, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ramonbrugman/node#13

Open

This was referenced Jul 21, 2021

[Snyk] Upgrade remark-preset-lint-node from 2.0.0 to 2.4.1 Zintexiss/node-22#39

Open

[Snyk] Upgrade remark-preset-lint-node from 2.2.0 to 2.4.1 MaxMood96/node#1

Open

snyk-bot mentioned this pull request Aug 11, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Andrea-MariaDB-2/node#9

Open

snyk-bot mentioned this pull request Nov 14, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Mhmonicox/node#5

Open

snyk-bot mentioned this pull request Dec 21, 2021

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 mrod0101/node#9

Open

This was referenced Jan 12, 2022

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 dannybrown13/node#16

Open

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 blackkhawkk/node#8

Open

This was referenced Feb 14, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Dixiejane/node#5

Open

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 SanchitMahajan236/node#8

Closed

snyk-bot mentioned this pull request Mar 15, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 davidmather/node#1

Open

snyk-bot mentioned this pull request Mar 22, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Bank4500/nodejs#5

Open

ashly1111111 mentioned this pull request May 5, 2023

[Snyk] Upgrade remark-preset-lint-node from 2.0.0 to 2.4.1 ashly1111111/node#10

Open

snyk-bot mentioned this pull request May 5, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#14

Open

nicholaschoi168 mentioned this pull request May 16, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nicholaschoi168/node#7

Open

ashly1111111 mentioned this pull request Jun 1, 2023

[Snyk] Upgrade remark-preset-lint-node from 2.0.0 to 2.4.1 ashly1111111/node#23

Open

pranathi-nallamilli mentioned this pull request Aug 5, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 pranathi-nallamilli/node#5

Open

ashly1111111 mentioned this pull request Sep 13, 2023

[Snyk] Upgrade remark-preset-lint-node from 2.0.0 to 2.4.1 ashly1111111/node#44

Open

JCsomeShots mentioned this pull request Sep 19, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 JCsomeShots/node#1

Open

maverick3312 mentioned this pull request Sep 28, 2023

[Snyk] Upgrade globals from 10.1.0 to 13.21.0 maverick3312/node#3

Open

kingjay66 mentioned this pull request Oct 15, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 kingjay66/node#4

Open

Jingyi090 mentioned this pull request Nov 17, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Jingyi090/node#1

Open

nickfnblum mentioned this pull request Nov 21, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nickfnblum/node#7

Open

ashly1111111 mentioned this pull request Nov 24, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#69

Open

aravindb26 mentioned this pull request Jan 4, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 aravindb26/node#1

Open

CxsLucyfer mentioned this pull request Jan 29, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CxsLucyfer/node#1

Open

gr00nd mentioned this pull request Feb 6, 2024

[Snyk] Upgrade globals from 10.1.0 to 13.24.0 gr00nd/node#10

Open

ahamedislam mentioned this pull request Feb 22, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ahamedislam/node#1

Open

DanyRay420 mentioned this pull request Feb 24, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 DanyRay420/node#2

Open

matrix-compute mentioned this pull request Mar 28, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 matrix-compute/node.js#2

Open

ashly1111111 mentioned this pull request Mar 29, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#94

Open

lairortega mentioned this pull request Apr 14, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lairortega/node#1

Open

SherfeyInv mentioned this pull request Apr 17, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 SherfeyInv/node#4

Merged

yaseenaljamal mentioned this pull request Apr 25, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 yaseenaljamal/node#5

Open

dannybrown13 mentioned this pull request May 7, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 dannybrown13/node#93

Open

CharliesAngel1 mentioned this pull request May 7, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CharliesAngel1/node#14

Open

snyk-io Bot mentioned this pull request May 21, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Hawthorne001/node2#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

crypto: add sync methods, deprecate optional callbacks#189

crypto: add sync methods, deprecate optional callbacks#189
jonathanong wants to merge 1 commit into
nodejs:v0.12from
jonathanong:crypto-async

jonathanong commented Dec 21, 2014

Uh oh!

piscisaureus commented Jan 10, 2015

Uh oh!

trevnorris commented Jan 13, 2015

Uh oh!

ruimarinho commented Jan 13, 2015

Uh oh!

trevnorris commented Jan 13, 2015

Uh oh!

piscisaureus commented Jan 13, 2015

Uh oh!

charmander Jan 14, 2015

Uh oh!

jonathanong commented Jan 23, 2015

Uh oh!

brendanashworth commented Jan 27, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

jonathanong commented Dec 21, 2014

Uh oh!

piscisaureus commented Jan 10, 2015

Uh oh!

trevnorris commented Jan 13, 2015

Uh oh!

ruimarinho commented Jan 13, 2015

Uh oh!

trevnorris commented Jan 13, 2015

Uh oh!

piscisaureus commented Jan 13, 2015

Uh oh!

charmander Jan 14, 2015

Choose a reason for hiding this comment

Uh oh!

jonathanong commented Jan 23, 2015

Uh oh!

brendanashworth commented Jan 27, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants