Skip to content

test: skip tests with common.skip#11585

Closed
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:skip-with-common-skip
Closed

test: skip tests with common.skip#11585
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:skip-with-common-skip

Conversation

@thefourtheye

@thefourtheye thefourtheye commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

The common.skip function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@thefourtheye
test: skip tests with common.skip
eaed633 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 27, 2017
gibfahn
gibfahn approved these changes Feb 27, 2017
View reviewed changes

@gibfahn gibfahn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@hiroppy

hiroppy commented Mar 1, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6637/

jasnell pushed a commit that referenced this pull request Mar 1, 2017
@thefourtheye @jasnell
test: skip tests with common.skip
5d4273d 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: #11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell

jasnell commented Mar 1, 2017

Copy link
Copy Markdown
Member

Landed in 5d4273d

@jasnell jasnell closed this Mar 1, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@thefourtheye @addaleax
test: skip tests with common.skip
2601c06 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: #11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
Merged
@thefourtheye thefourtheye deleted the skip-with-common-skip branch March 13, 2017 08:44
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@thefourtheye @MylesBorins
test: skip tests with common.skip
1427c0e 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: #11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@thefourtheye @MylesBorins
test: skip tests with common.skip
0322d3b 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: #11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@thefourtheye @andrew749
test: skip tests with common.skip
aa871cb 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: nodejs/node#11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@hiroppy hiroppy hiroppy approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@thefourtheye @hiroppy @jasnell @lpinca @cjihrig @richardlau @gibfahn @MylesBorins @nodejs-github-bot