Refine version update logic to allow arbitrary identifiers (e.g., "beta", not just "preview")#1193
Merged
Merged
Conversation
…ta", not just "preview") Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Node SDK publish-version calculation into a reusable helper to support incrementing prereleases without forcing a fixed identifier (e.g., allow beta, chicken, etc.), and updates the publish script and tests accordingly.
Changes:
- Extracted version selection/increment logic into
scripts/calculate-version.jswith updated prerelease identifier handling. - Simplified
scripts/get-version.jsto delegate tocalculateVersion(...). - Added Vitest coverage for key prerelease/stable/unstable increment scenarios.
Show a summary per file
| File | Description |
|---|---|
| nodejs/test/get-version.test.ts | Adds unit tests covering stable bumps and preserving prerelease identifiers. |
| nodejs/scripts/get-version.js | Switches CLI script to call the shared calculateVersion helper. |
| nodejs/scripts/calculate-version.js | New helper implementing version selection + increment rules, including “preserve identifier” behavior. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
Comment on lines
+34
to
+38
| const command = process.argv[2]; | ||
| const latest = await getLatestVersion("latest"); | ||
| const prerelease = await getLatestVersion("prerelease"); | ||
| const unstable = command === "unstable" ? await getLatestVersion("unstable") : undefined; | ||
| console.log(calculateVersion(command, { latest, prerelease, unstable })); |
Comment on lines
+35
to
+37
| const latest = await getLatestVersion("latest"); | ||
| const prerelease = await getLatestVersion("prerelease"); | ||
| const unstable = command === "unstable" ? await getLatestVersion("unstable") : undefined; |
Comment on lines
+6
to
+19
| if (!validCommands.includes(command)) { | ||
| throw new Error( | ||
| `Invalid argument, must be one of: ${validCommands.join(", ")}, got: "${command}"` | ||
| ); | ||
| } | ||
|
|
||
| if (!latest) { | ||
| throw new Error("No latest version found. Publish an initial version first."); | ||
| } | ||
|
|
||
| // Output the current latest version to stdout | ||
| if (command === "current") { | ||
| return latest; | ||
| } |
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.