Teardown improvement#55
Merged
Merged
Conversation
d4caae7 to
e9f5e52
Compare
bmonkman
reviewed
Aug 4, 2020
Contributor
There was a problem hiding this comment.
What do you think about prompting the user if they are sure before running any of the teardown steps?
Contributor
Author
There was a problem hiding this comment.
yeah perhaps a good idea since the terraform steps warn them before doing so 🤔
bmonkman
approved these changes
Aug 4, 2020
f559410 to
f1cc76b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously we had secret moved into
envso it can be referenced as a resource with the unknown name-prefix timestampmoving it back to secrets