random keepers: terraform state to keep state#32
Merged
Conversation
Contributor
|
So you have applied that multiple times and it still keeps generating new ones? |
davidcheung
commented
Apr 29, 2020
Contributor
Author
There was a problem hiding this comment.
So you have applied that multiple times and it still keeps generating new ones?
@bmonkman yeah, i have finally been able to pin point the problem, its the depends_on
not sure I understand why though
Contributor
Author
There was a problem hiding this comment.
and i added it trying to solve the initial creation where it errors out saying
AWSCURRENT version not found or something along the lines of that
Contributor
There was a problem hiding this comment.
That shouldn't require depends_on because the line above it already creates an explicit dependency. Weird that it would cause (or fix) any problems though...
bmonkman
approved these changes
Apr 30, 2020
ffa318f to
bb52188
Compare
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
random keepers: terraform state to keep state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still testing this, i tried it and couldnt seem to get it to work...
I'm wondering if its the way
"${data.aws_secretsmanager_secret_version..secret_strirds_master_secretng}"is read, it always thinks its new (maybe it doesnt keep a state of it?) , or maybe i did something wrong