Skip to content

Fix VM with ISO attached migration issue#3935

Merged
yadvr merged 1 commit into
apache:4.13from
shapeblue:vmisomigration
Mar 6, 2020
Merged

Fix VM with ISO attached migration issue#3935
yadvr merged 1 commit into
apache:4.13from
shapeblue:vmisomigration

Conversation

@nvazquez

@nvazquez nvazquez commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Description

As previously described by PR #3929:
If vm has attached ISO, the migration fails with error message "org.libvirt.LibvirtException: Cannot access storage file /mnt/b33e5a1d-e4ea-3465-b6ac-c98dc8ff8af0/207-2-cc5fd717-2d57-3bb3-bcf6-2c930268db6c.iso"

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez nvazquez requested a review from weizhouapache March 5, 2020 04:55
@nvazquez

nvazquez commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1002

@yadvr yadvr added this to the 4.14.0.0 milestone Mar 5, 2020
@yadvr

yadvr commented Mar 5, 2020

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok.
create a vm with registered iso, migrations succeed.

did not test iso which is direct downloaded.

@weizhouapache

Copy link
Copy Markdown
Member

@nvazquez can you change the destination branch to 4.13 ?
I think same issue exists in 4.13

@nvazquez nvazquez changed the base branch from master to 4.13 March 5, 2020 14:12
@nvazquez

nvazquez commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1007

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1189)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27825 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3935-t1189-kvm-centos7.zip
Smoke tests completed. 81 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez

nvazquez commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

@weizhouapache @rhtyd branch base moved to 4.13 - also verified ISO direct download and migration works

@yadvr yadvr modified the milestones: 4.14.0.0, 4.13.1.0 Mar 6, 2020
@yadvr yadvr merged commit bd7d41b into apache:4.13 Mar 6, 2020
@nvazquez nvazquez deleted the vmisomigration branch April 6, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants