Skip to content

Fix network GC error that's failing a smoketests on master#3115

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-master-travis-test-fails
Jan 13, 2019
Merged

Fix network GC error that's failing a smoketests on master#3115
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-master-travis-test-fails

Conversation

@yadvr

@yadvr yadvr commented Dec 31, 2018

Copy link
Copy Markdown
Member

This PR attempts to fix various test failures on master:

  1. Fixes Network GC error on master/4.12 #2935: This fixes the variable name to adhere to the DB framework convention
    as defined by the method interceptor that creates attributes:

https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/SearchBase.java#L480

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This fixes the variable name to adhere to the DB framework convention
as defined by the method interceptor that creates attributes:

https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/SearchBase.java#L480

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added the type:bug label Dec 31, 2018

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr

yadvr commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

@rafaelweingartner @GabrielBrascher guys this is still in progress, unfortunately, I'm unable to work on stabilizing failing master smoketests this week, I'll try next week. I think there are a few in Travis+{smoke, component}-tests and few on Trillian+smoketests. If you've time, please feel free to fix and push changes to the branch (acs committers can do that on any PRs).

@rafaelweingartner

Copy link
Copy Markdown
Member

Ah, so you are not targeting a single problem. Thanks for the first fix.

@GabrielBrascher

Copy link
Copy Markdown
Member

I also thought it was targeting a single problem; I saw that it fixed some tests and imagined it was all good to go. Thanks for the effort @rhtyd!

@yadvr yadvr changed the title WIP: Fix failing tests on master Fix network GC error that's failing a smoketests on master Jan 13, 2019
@yadvr

yadvr commented Jan 13, 2019

Copy link
Copy Markdown
Member Author

I'm not sure when I'll be able to fix other issues, I'll proceed with merging this based on Travis smoketests that at least fix the network gc error.

@yadvr yadvr merged commit 8849382 into apache:master Jan 13, 2019
@rafaelweingartner

rafaelweingartner commented Jan 13, 2019

Copy link
Copy Markdown
Member

Thanks @rhtyd. Gabriel and I are actually working on the other issues already. I decided to open a PR per issue, because I think that it gets easier to review and to discuss them.

Thanks for this one ;)

@yadvr

yadvr commented Jan 13, 2019

Copy link
Copy Markdown
Member Author

Thanks @rafaelweingartner, yes I saw some PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network GC error on master/4.12

3 participants