Skip to content

[dotnet] [build] Simplify version.bzl file name#17399

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-build-version
Apr 27, 2026
Merged

[dotnet] [build] Simplify version.bzl file name#17399
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-build-version

Conversation

@nvborisenko
Copy link
Copy Markdown
Member

This pull request renames the .NET version and metadata file from selenium-dotnet-version.bzl to version.bzl and updates all references throughout the codebase and documentation to use the new file name. This change improves clarity and consistency in file naming and ensures all scripts, build files, and documentation point to the correct location.

Build and configuration updates:

  • Renamed dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl and updated all load statements in Bazel build files (defs.bzl, BUILD.bazel, etc.) to reference the new file name. [1] [2] [3] [4] [5]
  • Updated the file path in scripts and Rake tasks (rake_tasks/dotnet.rake, scripts/update_cdp.py) to use dotnet/version.bzl instead of the old file name. [1] [2] [3]

Documentation updates:

  • Updated references in dotnet/src/webdriver/DevTools/README.md to point to version.bzl for DevTools protocol version support instructions. [1] [2]

Metadata adjustments:

  • Moved the definition of ASSEMBLY_VERSION into version.bzl for consistency.

No functional code changes were made; this is a refactor for improved maintainability.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • Cleanup (formatting, renaming)

Copilot AI review requested due to automatic review settings April 27, 2026 10:26
@selenium-ci selenium-ci added C-dotnet .NET Bindings B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes labels Apr 27, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Simplify .NET version file naming convention

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Rename dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl
• Update all Bazel load statements across build files
• Update file references in scripts and Rake tasks
• Update documentation links to reflect new file name

Grey Divider

File Changes

1. dotnet/defs.bzl ⚙️ Configuration changes +1/-1

Update version file reference in defs

• Updated load statement to reference version.bzl instead of selenium-dotnet-version.bzl

dotnet/defs.bzl


2. dotnet/version.bzl ⚙️ Configuration changes +1/-2

Reorganize assembly version definitions

• Removed ASSEMBLY_VERSION and SUPPORTED_NET_STANDARD_VERSIONS from initial section
• Moved ASSEMBLY_VERSION definition to end of file after other assembly metadata
• File represents the renamed version of selenium-dotnet-version.bzl

dotnet/version.bzl


3. scripts/update_cdp.py ⚙️ Configuration changes +1/-1

Update version file path in CDP script

• Updated file path reference from dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl

scripts/update_cdp.py


View more (5)
4. rake_tasks/dotnet.rake ⚙️ Configuration changes +2/-2

Update version file references in Rake tasks

• Updated file path in dotnet_version function from dotnet/selenium-dotnet-version.bzl to
 dotnet/version.bzl
• Updated file path in version task from old to new file name

rake_tasks/dotnet.rake


5. dotnet/src/support/BUILD.bazel ⚙️ Configuration changes +1/-1

Update version file reference in support

• Updated load statement to reference version.bzl instead of selenium-dotnet-version.bzl

dotnet/src/support/BUILD.bazel


6. dotnet/src/webdriver/BUILD.bazel ⚙️ Configuration changes +1/-1

Update version file reference in webdriver

• Updated load statement to reference version.bzl instead of selenium-dotnet-version.bzl

dotnet/src/webdriver/BUILD.bazel


7. dotnet/src/webdriver/DevTools/BUILD.bazel ⚙️ Configuration changes +1/-1

Update version file reference in DevTools

• Updated load statement to reference version.bzl instead of selenium-dotnet-version.bzl

dotnet/src/webdriver/DevTools/BUILD.bazel


8. dotnet/src/webdriver/DevTools/README.md 📝 Documentation +2/-2

Update documentation file references

• Updated documentation links from selenium-dotnet-version.bzl to version.bzl in two locations
• Updated GitHub repository links to point to new file name

dotnet/src/webdriver/DevTools/README.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Apr 27, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@selenium-ci
Copy link
Copy Markdown
Member

Thank you, @nvborisenko for this code suggestion.

The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.

We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the .NET Bazel version/metadata file name by renaming dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl and updating all in-repo references so build rules, scripts, and docs consistently point to the new location.

Changes:

  • Updated Bazel load(...) statements across .NET BUILD/defs files to use //dotnet:version.bzl.
  • Updated tooling references in scripts/update_cdp.py and rake_tasks/dotnet.rake to read/write dotnet/version.bzl.
  • Updated DevTools README links/instructions to reference the renamed file.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/update_cdp.py Updates the CDP update script to edit dotnet/version.bzl instead of the old filename.
rake_tasks/dotnet.rake Updates version reading/writing tasks to use the renamed .bzl file.
dotnet/version.bzl Houses the .NET version/assembly metadata under the simplified filename.
dotnet/src/webdriver/DevTools/README.md Updates documentation references/links to the new .bzl filename.
dotnet/src/webdriver/DevTools/BUILD.bazel Loads SUPPORTED_DEVTOOLS_VERSIONS from //dotnet:version.bzl.
dotnet/src/webdriver/BUILD.bazel Loads assembly/version metadata from //dotnet:version.bzl.
dotnet/src/support/BUILD.bazel Loads assembly/version metadata from //dotnet:version.bzl.
dotnet/defs.bzl Loads SUPPORTED_DEVTOOLS_VERSIONS from //dotnet:version.bzl.

@nvborisenko nvborisenko merged commit e68fadc into SeleniumHQ:trunk Apr 27, 2026
55 of 56 checks passed
@nvborisenko nvborisenko deleted the dotnet-build-version branch April 27, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants