[dotnet] [build] Simplify version.bzl file name#17399
Conversation
Review Summary by QodoSimplify .NET version file naming convention
WalkthroughsDescription• Rename dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl • Update all Bazel load statements across build files • Update file references in scripts and Rake tasks • Update documentation links to reflect new file name File Changes1. dotnet/defs.bzl
|
|
Thank you, @nvborisenko for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
There was a problem hiding this comment.
Pull request overview
This PR standardizes the .NET Bazel version/metadata file name by renaming dotnet/selenium-dotnet-version.bzl to dotnet/version.bzl and updating all in-repo references so build rules, scripts, and docs consistently point to the new location.
Changes:
- Updated Bazel
load(...)statements across .NET BUILD/defs files to use//dotnet:version.bzl. - Updated tooling references in
scripts/update_cdp.pyandrake_tasks/dotnet.raketo read/writedotnet/version.bzl. - Updated DevTools README links/instructions to reference the renamed file.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/update_cdp.py | Updates the CDP update script to edit dotnet/version.bzl instead of the old filename. |
| rake_tasks/dotnet.rake | Updates version reading/writing tasks to use the renamed .bzl file. |
| dotnet/version.bzl | Houses the .NET version/assembly metadata under the simplified filename. |
| dotnet/src/webdriver/DevTools/README.md | Updates documentation references/links to the new .bzl filename. |
| dotnet/src/webdriver/DevTools/BUILD.bazel | Loads SUPPORTED_DEVTOOLS_VERSIONS from //dotnet:version.bzl. |
| dotnet/src/webdriver/BUILD.bazel | Loads assembly/version metadata from //dotnet:version.bzl. |
| dotnet/src/support/BUILD.bazel | Loads assembly/version metadata from //dotnet:version.bzl. |
| dotnet/defs.bzl | Loads SUPPORTED_DEVTOOLS_VERSIONS from //dotnet:version.bzl. |
This pull request renames the
.NETversion and metadata file fromselenium-dotnet-version.bzltoversion.bzland updates all references throughout the codebase and documentation to use the new file name. This change improves clarity and consistency in file naming and ensures all scripts, build files, and documentation point to the correct location.Build and configuration updates:
dotnet/selenium-dotnet-version.bzltodotnet/version.bzland updated allloadstatements in Bazel build files (defs.bzl,BUILD.bazel, etc.) to reference the new file name. [1] [2] [3] [4] [5]rake_tasks/dotnet.rake,scripts/update_cdp.py) to usedotnet/version.bzlinstead of the old file name. [1] [2] [3]Documentation updates:
dotnet/src/webdriver/DevTools/README.mdto point toversion.bzlfor DevTools protocol version support instructions. [1] [2]Metadata adjustments:
ASSEMBLY_VERSIONintoversion.bzlfor consistency.No functional code changes were made; this is a refactor for improved maintainability.
🤖 AI assistance
🔄 Types of changes