Conversation
Fixing unpersisted insulin data source preference
kenstack
pushed a commit
to kenstack/Loop
that referenced
this pull request
Aug 23, 2018
* Put a glucose chart on the watch. This incorporates a ton of fine work by Eric Jensen, but I've squashed it down into a single commit for ease of management. The watch now has two discrete pages, one which is the standard actions based interface, the second is an information interface which shows the IOB, COB, basal rate and a glucose chart. Glucose data is read from HealthKit on the watch. Sometimes this lags behind so we also make requests to backfill glucose data as necessary. We're also minimizing the amount of data sent over BLE as much as possible since BLE is slow and less reliable. * Fix filename mismatches in comments * Prototype of a SpriteKit-based glucose chart * Tweak the scene size for 42mm watches * Add the rest of the chart components * Set high watermark higher for mg/dl * Clean up pause/unpause semantics and set the max hours to 4 * The crown now adjusts the height of the graph * Fix override range rendering to match the Loop app ui * Small optimizations * Clean up the rendering code to pause between data changes * Remove debug code * Highlight the upper BG when it changes * Make updateGlucoseChart async to avoid hitting CPU limits * More stability fixes & remove graph corner radius * Force updateNode() to run on the main queue to avoid contention * Improve watch size detection code * Switch to the more efficient SpriteNode * Only cache 4 hours of glucose history * Remove pause/unpause code- it doesn't save significant CPU * Try unpausing the WKInterfaceSKScene to get the animation to stop freezing * Revert "Remove pause/unpause code- it doesn't save significant CPU" This reverts commit deeddb2. * Move the IOB/COB below the graph * Whitespace and comment cleanup * Animate moving points on the chart * Only animate the predicted path when adjusting the y-axis * Clean up sprite animation code * Adjust scene size on 38mm watch * Only show overrides that haven't yet expired * Fix node expiration code * Break the more complex updateSprite into two more manageable pieces: getSprite() and SKSpriteKitNode.move() * Clean up variable names and comments around how we expire inactive nodes for readability * Add some comments to aid readability * Change visible hours with force touch menu * Revert changes in tools versions in storyboard * Add icons for duration menu * Rearrange menu actions * Fix asset locations for graph menu icons * Make mmol/L graph limits be integers * Force minimum height for dated range rects * Make target ranges more visible * Only show future part of override ranges * Revert "Only show future part of override ranges" This reverts commit 0b25d2e. * Expire overrides once they move into past * Set min range height via variable * Rearrange image assets for graph menu * Clarify minimum height on dated range * Don't send expired overrides in watch context * Rearrange testing of override end date * Treat nil COB as zero * Use signed integers for predicted glucose values. * Remove frame, add background color, move labels to one line
ps2
pushed a commit
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the new Nightscout upload preference wasn't saved across app launches