Skip to content

Nightscout upload#42

Merged
loudnate merged 9 commits into
LoopKit:0.4.0from
ps2:nsupload
Jun 26, 2016
Merged

Nightscout upload#42
loudnate merged 9 commits into
LoopKit:0.4.0from
ps2:nsupload

Conversation

@ps2

@ps2 ps2 commented Jun 24, 2016

Copy link
Copy Markdown
Collaborator

Uploads the following to nightscout:

  • Treatments (bolus events, temp basals, and meter events) for all supported pumps.
  • Pump state if you are using a mysentry compatible pump (523 and up).
  • BG values if you are using enlite and a mysentry compatible pump (523 and up).

@ps2

ps2 commented Jun 24, 2016

Copy link
Copy Markdown
Collaborator Author

Loop has changed a fair amount since the version of Naterade that I've been using in production. I haven't tested this branch in production yet. Hoping to do so soon. There are also some new changes to NightscoutUploadKit that haven't had much testing beyond my test setup.

@loudnate

Copy link
Copy Markdown
Collaborator

Awesome! Thanks for getting it to PR this quickly. I'll review it tonight (brief check looked good) and merge to 0.4.0.

With word from you that it's working, I'll prioritize getting this out to users ASAP, before finishing DoseStore integration.

On Jun 24, 2016, at 9:43 AM, Pete Schwamb notifications@github.com wrote:

Loop has changed a fair amount since the version of Naterade that I've been using in production. I haven't tested this branch in production yet. Hoping to do so soon. There are also some new changes to NightscoutUploadKit that haven't had much testing beyond my test setup.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Comment thread Loop/Managers/DeviceDataManager.swift Outdated
/// Notification posted by the instance when new glucose data was processed
static let GlucoseUpdatedNotification = "com.loudnate.Naterade.notification.GlucoseUpdated"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you feel strongly about the whitespace on blank lines? If so, then I'll change my settings.

Here's my current Xcode setting:
screen shot 2016-06-24 at 6 45 14 pm

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, no! Had no idea about that setting. lack of gofmt strikes again.

@loudnate

Copy link
Copy Markdown
Collaborator

LGTM! I'm going to merge this down. Let's tag a RileyLink release, too.

@amazaheri

Copy link
Copy Markdown

awesome job guys! going to do a pull tonight

@ps2

ps2 commented Jun 25, 2016

Copy link
Copy Markdown
Collaborator Author

Ok sounds good!

@ps2

ps2 commented Jun 26, 2016

Copy link
Copy Markdown
Collaborator Author

This branch has been running well for me since last night. Actually been having a ton of treatments and corrections. Vacation fun with lots of sweets and carbs.

@loudnate

Copy link
Copy Markdown
Collaborator

Awesome! Awaiting your approval on the RL 0.5.0 release so I can point the Cartfile back to a release tag.

On Jun 25, 2016, at 7:13 PM, Pete Schwamb notifications@github.com wrote:

This branch has been running well for me since last night. Actually been having a ton of treatments and corrections. Vacation fun with lots of sweets and carbs.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@loudnate loudnate merged commit 2a0822d into LoopKit:0.4.0 Jun 26, 2016
@ps2 ps2 deleted the nsupload branch August 7, 2016 17:08
erikdi pushed a commit to erikdi/Loop that referenced this pull request Feb 10, 2019
* Updating to Swift 2.3

* Swift 3

* Updating travis

* Updating project compatibility version; seeing if whole module optimization works this time 'round.

* Travis simulator destination for tests

* Turn off Cocoapods building in Carthage for now

* Don't build the cocoapods example
ps2 pushed a commit that referenced this pull request Jan 18, 2020
removed ShareClient residual from Loop build phases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants