Handle exceptions by using traceback.format_exc instead of extract_tb#58
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
yxd-hde
reviewed
Nov 22, 2019
| result = json.dumps({ | ||
| "errorMessage": str(err[1]), | ||
| "stackTrace": traceback.extract_tb(err[2]), | ||
| "stackTrace": traceback.format_exc(), |
Contributor
There was a problem hiding this comment.
How about using traceback.format_tb(err[2]) instead?
Contributor
Author
There was a problem hiding this comment.
Good idea, that makes it look more like the error response provided by AWS now.
yxd-hde
suggested changes
Nov 22, 2019
yxd-hde
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your PR. Would you please check my comment? Thanks!
yxd-hde
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #57, where we were seeing
TypeError: Object of type FrameSummary is not JSON serializableif the handler function throws an exception.traceback.format_excreturns a string that can be easily turned into JSON.