fix(asgi): Gate query string and client IP behind send_default_pii#6501
fix(asgi): Gate query string and client IP behind send_default_pii#6501ericapisani wants to merge 5 commits into
Conversation
Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 666e6fb. Configure here.
Codecov Results 📊✅ 89282 passed | ⏭️ 6013 skipped | Total: 95295 | Pass Rate: 93.69% | Execution Time: 301m 7s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2392 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.80% 89.80% —%
==========================================
Files 192 192 —
Lines 23453 23456 +3
Branches 8060 8062 +2
==========================================
+ Hits 21061 21064 +3
- Misses 2392 2392 —
- Partials 1329 1329 —Generated by Codecov Action |
|
If Warden is right about
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb14dd0. Configure here.

Move http.query and client.address attribute collection inside the
should_send_default_pii() check so sensitive values are not captured
by default.
Fixes PY-2514
Fixes #6499