Skip to content

feat: Added support for modules being able to supply a default value for a parameter when the condition is not met. Also improved documentation.#420

Merged
bmonkman merged 3 commits into
mainfrom
add-condition-default-value-support
Oct 6, 2021
Merged

feat: Added support for modules being able to supply a default value for a parameter when the condition is not met. Also improved documentation.#420
bmonkman merged 3 commits into
mainfrom
add-condition-default-value-support

Conversation

@bmonkman

@bmonkman bmonkman commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

…for a parameter when the condition is not met. Also improved documentation.
@bmonkman bmonkman requested a review from davidcheung October 6, 2021 01:24
@bmonkman

bmonkman commented Oct 6, 2021

Copy link
Copy Markdown
Contributor Author

(closes #418)

@bmonkman

bmonkman commented Oct 6, 2021

Copy link
Copy Markdown
Contributor Author

Removed the docs dir which is now deprecated.

Comment thread cmd/zero.go
if err := rootCmd.Execute(); err != nil {
fmt.Println(err)
os.Exit(1)
if len(os.Args) > 1 {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that just running zero would exit with no output. Now it will show the usage screen

@davidcheung

Copy link
Copy Markdown
Contributor

stretchr/testify#1091 looks like might need to bump go version go 1.13+

@bmonkman bmonkman merged commit 65d4147 into main Oct 6, 2021
@bmonkman bmonkman deleted the add-condition-default-value-support branch October 6, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants