fix: correct treap split() comparison to match docstring behavior#14762
Closed
maitriupadhyay03-cell wants to merge 2 commits into
Closed
fix: correct treap split() comparison to match docstring behavior#14762maitriupadhyay03-cell wants to merge 2 commits into
maitriupadhyay03-cell wants to merge 2 commits into
Conversation
…gorithms#7854) The split() function in treap.py uses `<` comparison but the docstring states that the right subtree should contain values "greater or equal" to the split value. This fix changes `elif value < root.value:` to `elif value <= root.value:` so that equal values go to the right subtree as documented. Fixes TheAlgorithms#7854
Closing this pull request as invalid@maitriupadhyay03-cell, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
The
split()function indata_structures/binary_tree/treap.pyuses a strict<comparison, but the docstring states:This means when splitting by a value that already exists in the treap, the existing node ends up in the LEFT subtree instead of the RIGHT subtree, which contradicts the documented behavior.
Fix: Changed
elif value < root.value:toelif value <= root.value:so that equal values go to the right subtree as documented.Fixes #7854
Checklist: