test: fix child-process-uid-gid on Windows#8924
Closed
targos wants to merge 1 commit into
Closed
Conversation
The process.getuid method does not exist on this platform. Ref: #8864
2 tasks
Member
Author
cjihrig
approved these changes
Oct 4, 2016
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
Perhaps we should fast track this.
Member
Author
|
I agree. Feel free to land it as I'm not on my dev computer. |
Member
|
LGTM |
Trott
approved these changes
Oct 4, 2016
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM and definitely agree on the fast-tracking.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 4, 2016
The process.getuid method does not exist on this platform. Ref: nodejs#8864 PR-URL: nodejs#8924 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 1554735 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
The process.getuid method does not exist on this platform.
Ref: #8864