Stop importing on runtime dependent projects as submodules#544
Conversation
Stop importing on runtime submodules of this project: gitdb, smmap. This overrides any other method of setting `SYSPATH`, eg: - pip install -e ./gitdb.git - pip install -e . - pip install git+https://... - dependent projects for IDes(LiClipse & PyCharm). - Manual maintain path.
|
Indeed, CI-testing becomes impossible, unless we pip install From the other side, this allows to CI-test specific combinations, by modifying the |
Current coverage is 94.40% (diff: 100%)@@ master #544 diff @@
==========================================
Files 63 63
Lines 9882 9874 -8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9326 9322 -4
+ Misses 556 552 -4
Partials 0 0
|
|
@ankostis This PR has been stale for a while now - what do you suggest we should do with it? Giving it more time is absolutely an option, and merging it certainly is too. Even though I am the biggest fan of this as GitPython will just work out of the box in the checkout location. |
|
I would suggest not to merge it. |
|
@ankostis Thanks for letting me know. As per your recommendation, I am closing it. |
As discussed in the last comments of #511, the projects stops relying on git's submodules to import its dependencies. That means that for TravisCI to succeed, the correct revisions must exist in PyPi, and hence, more frequent releases.