Skip to content

gh-93096: Remove -t and -v flags from pickle cli#131068

Merged
vstinner merged 2 commits into
python:mainfrom
donbarbos:issue-93096-pickle
Mar 11, 2025
Merged

gh-93096: Remove -t and -v flags from pickle cli#131068
vstinner merged 2 commits into
python:mainfrom
donbarbos:issue-93096-pickle

Conversation

@donbarbos

@donbarbos donbarbos commented Mar 11, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor
  • added load doctest to unittest
  • we still can run doctests using: ./python -m doctest Lib/pickle.py -v

@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2025
Open
27 tasks
vstinner
vstinner reviewed Mar 11, 2025
View reviewed changes
Comment thread Lib/test/test_pickle.py Outdated

def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite())
tests.addTest(doctest.DocTestSuite(pickle))

@vstinner vstinner Mar 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this looks like a bugfix. It should be backported. Can you extract this change into a new PR? It's not directly related to CLI changes.

@donbarbos donbarbos Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, should i open new issue or can i send PR for the current issue?

@vstinner vstinner Mar 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reuse the same issue.

vstinner
vstinner reviewed Mar 11, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

@donbarbos

donbarbos commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

I think it can be suggested in issue #130160

vstinner
vstinner approved these changes Mar 11, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: Are you ok with these changes?

@vstinner

vstinner commented Mar 11, 2025

Copy link
Copy Markdown
Member

I think it can be suggested in issue #130160

You can reuse #93096 or create a new issue.

serhiy-storchaka
serhiy-storchaka approved these changes Mar 11, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 425e0af into python:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donbarbos @vstinner @serhiy-storchaka