[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953)

[mcepl]

Manual port of gh-102953 to 3.10.

Please, review.

• Issue: Implement PEP 706 – Filter for tarfile.extractall #102950

[encukou]

Thanks for getting to this sooner than I did!
But see https://github.com/python/cpython/pull/103832/commits for the changes needed in the backport.

[mcepl]

I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included.

[encukou]

Ah, sorry! I just looked at the versionchanged:: 3.12 and gave a quick comment. Will do a proper review later.

[mcepl]

Yes, you were right, I missed those, not sure how I have managed to do that.

[mcepl]

I don't understand those Windows failures … shouldn’t it be covered by ae62b3a ?

[encukou]

No. ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it.

This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though.

[encukou]

It's related to a change made while backporting, going from

        if mode is not None and os_helper.can_chmod():

to just

        if mode is not None:

The can_chmod() determines whether chmod can set all the mode bits. According to the docs, it's only limited on Windows, so I'll hardcode that. (It's also limited on WASI, but in 3.10 tests we don't care.)

I can't push fixes to your repo so I opened #104327.

[mcepl]

I can't push fixes to your repo so I opened #104327.

Sorry about that, I don’t know how to set it up with the existing PR.

[mcepl]

Couldn’t you just make PR to https://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ?

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ab6233 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[encukou]

I don't think I could run CPython buildbots on another repo.
But since you've updated this PR quickly, I'll run them here.

[encukou]

The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3.

[encukou]

Thanks for the backport!

[mcepl]

So, now 3.9! :)