Skip to content

Add SQLite 3.33.0 for CPython#22

Closed
erlend-aasland wants to merge 1 commit into
python:sqlitefrom
erlend-aasland:sqlite-3.33.x
Closed

Add SQLite 3.33.0 for CPython#22
erlend-aasland wants to merge 1 commit into
python:sqlitefrom
erlend-aasland:sqlite-3.33.x

Conversation

@erlend-aasland

Copy link
Copy Markdown
Collaborator

@erlend-aasland

Copy link
Copy Markdown
Collaborator Author

@zooba, would you mind reviewing this?

@zooba

zooba commented Oct 7, 2020

Copy link
Copy Markdown
Member

Thanks. Ultimately, the review that I need to do is download and check in the source code myself to make sure it's unmodified, so I'll just push it directly.

(Also, my GitHub notifications is a dumpster fire, so I never see anything. Better to ping me on bugs.python.org)

@erlend-aasland

Copy link
Copy Markdown
Collaborator Author

Thanks. Ultimately, the review that I need to do is download and check in the source code myself to make sure it's unmodified, so I'll just push it directly.

Ok.

(Also, my GitHub notifications is a dumpster fire, so I never see anything. Better to ping me on bugs.python.org)

Got it!

@zooba

zooba commented Oct 7, 2020

Copy link
Copy Markdown
Member

to make sure it's unmodified

FWIW, this is a terrible pain, because they list their hashes as "sha3" without clarifying which length, and the hash for the .zip file doesn't match any of the ones I can generate 😆

Luckily they list the hashes for the main source file separately and those check out.

@zooba

zooba commented Oct 7, 2020

Copy link
Copy Markdown
Member

Okay, my tag is up: https://github.com/python/cpython-source-deps/tree/sqlite-3.33.0.0

In theory, your diff should collapse to nothing now, but I'm not sure how/when GitHub will figure that out.

@zooba zooba closed this Oct 7, 2020
@erlend-aasland erlend-aasland deleted the sqlite-3.33.x branch October 7, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants