Skip to content

cares: sync with upstream, fully adopt v1.12.0#9332

Closed
rvagg wants to merge 7 commits into
nodejs:masterfrom
rvagg:c-ares-1.12.0
Closed

cares: sync with upstream, fully adopt v1.12.0#9332
rvagg wants to merge 7 commits into
nodejs:masterfrom
rvagg:c-ares-1.12.0

Conversation

@rvagg

@rvagg rvagg commented Oct 28, 2016

Copy link
Copy Markdown
Member

Not a big change but previous sync's have been piecemeal so this is a full job. I've also redone most of the config headers in config/ (haven't touched the AIX one but it still compiles and passes).

Passing CI @ https://ci.nodejs.org/job/node-test-commit/5830/ minus unrelated freebsd failures.

I believe this is ABI and API stable so could be backported through to v4.x.

@mscdex mscdex added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Oct 28, 2016
@rvagg

rvagg commented Oct 28, 2016

Copy link
Copy Markdown
Member Author

@indutny @bnoordhuis I think you two might be best equipped to review this one

@sam-github

Copy link
Copy Markdown
Contributor

@rvagg @richardlau should the AIX header be updated, too, or is it just cosmetic?

@gibfahn

gibfahn commented Oct 28, 2016

Copy link
Copy Markdown
Member

cc/ @nodejs/platform-aix

@richardlau

Copy link
Copy Markdown
Member

Looking at the changes to the config/ headers for the other platforms in this pull request I think the AIX header should be updated too.

@rvagg Looks like this change also adds deps/cares/LICENSE.md -- Presumably we want to update the license-builder.sh script to use this file and regenerate the license?

@rvagg

rvagg commented Oct 29, 2016

Copy link
Copy Markdown
Member Author

updated license-builder.sh, thanks @richardlau, that's why I included LICENSE.md after all!

@rvagg

rvagg commented Oct 29, 2016

Copy link
Copy Markdown
Member Author

I've updated AIX config, I had trouble getting access to an AIX machine yesterday but I've figured out my problem. PTAL IBMers.

@gibfahn

gibfahn commented Oct 29, 2016

Copy link
Copy Markdown
Member

@jasnell

jasnell commented Mar 24, 2017

Copy link
Copy Markdown
Member

Ping... updates?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 24, 2017
@gibfahn

gibfahn commented Mar 24, 2017

Copy link
Copy Markdown
Member

cc/ @nodejs/platform-aix regarding the AIX header update.

@fhinkel

fhinkel commented May 26, 2017

Copy link
Copy Markdown
Member

@rvagg Any idea if the CI failures are related? Is this ready to land?

@mscdex

mscdex commented Jun 24, 2017

Copy link
Copy Markdown
Contributor

c-ares 1.13.0 is available now. If we can land that instead, that will also take care of #13897 in the process.

@kasicka

kasicka commented Jun 27, 2017

Copy link
Copy Markdown

Is there any ETA on this?

@BridgeAR

Copy link
Copy Markdown
Member

@rvagg are you going to follow up on this?

@BridgeAR

Copy link
Copy Markdown
Member

Closing this due to a long inactivity. Please feel free to reopen if you want to follow up on this @rvagg

@BridgeAR BridgeAR closed this Sep 12, 2017
@rvagg

rvagg commented Sep 13, 2017

Copy link
Copy Markdown
Member Author

Thanks for the nudge @BridgeAR! Sorry for my unresponsiveness here, I'm trying to get back on the 🐴 now. Opened at new PR @ #15378 with 1.13.0 but it still has a couple of failures. Any additional help there would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. stalled Issues and PRs that are stalled.

Projects

None yet

Development

Successfully merging this pull request may close these issues.