Skip to content

crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411

Open
panva wants to merge 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes
Open

crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
panva wants to merge 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented May 18, 2026

Closes #63393

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 18, 2026
@panva panva force-pushed the crypto-add-siv-modes branch from a1ea9b7 to 127a852 Compare May 18, 2026 13:24
@panva panva requested a review from tniessen May 18, 2026 13:24
@panva panva added the crypto Issues and PRs related to the crypto subsystem. label May 18, 2026
@panva panva marked this pull request as ready for review May 18, 2026 13:24
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 18, 2026
Closes nodejs#63393

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the crypto-add-siv-modes branch from 687e02b to b5764bc Compare May 18, 2026 13:45
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (550f195) to head (944bf43).
⚠️ Report is 168 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_cipher.cc 85.71% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63411      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.02%     
==========================================
  Files         714      714              
  Lines      225648   225776     +128     
  Branches    42711    42741      +30     
==========================================
+ Hits       203237   203314      +77     
- Misses      14200    14228      +28     
- Partials     8211     8234      +23     
Files with missing lines Coverage Δ
src/crypto/crypto_cipher.h 66.66% <ø> (ø)
src/crypto/crypto_cipher.cc 78.28% <85.71%> (+0.85%) ⬆️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added review wanted PRs that need reviews. semver-minor PRs that contain new features and should be released in the next minor version. and removed dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 25, 2026
@panva panva requested review from ChALkeR and jasnell June 7, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()

3 participants