Skip to content

doc: clarify that __dirname is module local#6018

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-globals-dirname-clarification
Closed

doc: clarify that __dirname is module local#6018
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-globals-dirname-clarification

Conversation

@jasnell

@jasnell jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Clarify the __dirname is module local.

Fixes: #5525

@jasnell jasnell added the doc Issues and PRs related to the documentations. label Apr 2, 2016
@jasnell

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

@nodejs/documentation

@thefourtheye

Copy link
Copy Markdown
Contributor

LGTM.

@r-52

r-52 commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@cjihrig

cjihrig commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell added a commit that referenced this pull request Apr 2, 2016
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

Landed in c06824b

@jasnell jasnell closed this Apr 2, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants