doc: add util.types.isModuleNamespaceObject()#20616
Conversation
There was a problem hiding this comment.
as much as i hate that line, every other one has that line.
There was a problem hiding this comment.
I can open another or after this to remove it from all of the docs at once.
There was a problem hiding this comment.
(Not necessarily true if there is a then export.)
I’d use an import * as ns example.
There was a problem hiding this comment.
it won't pass lint if i do that, i'd have to ignore the block
There was a problem hiding this comment.
It seems the comment is a bit confusing: as this is not just a REPL command, this line does not return in the usual sense, but the function returns Promise resolved to undefined. Maybe we should add return and change the comment into Resolves...?
There was a problem hiding this comment.
does it look okay at this point?
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
326cfa2 to
19c4f9b
Compare
|
landed in f1cdd77 |
PR-URL: #20616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #20616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Checklist