Skip to content

doc: add tls.parseCertString()#14196

Closed
XadillaX wants to merge 2 commits into
nodejs:v8.x-stagingfrom
XadillaX:doc/tls.parseCertString
Closed

doc: add tls.parseCertString()#14196
XadillaX wants to merge 2 commits into
nodejs:v8.x-stagingfrom
XadillaX:doc/tls.parseCertString

Conversation

@XadillaX

@XadillaX XadillaX commented Jul 12, 2017

Copy link
Copy Markdown
Contributor

Refs: #14193

Checklist
Affected core subsystem(s)

doc, tls

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jul 12, 2017

@refack refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

Comment thread doc/api/tls.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`str` {string} A Cert in [`ini`][] format.

[`ini`]: https://en.wikipedia.org/wiki/INI_file

Comment thread doc/api/tls.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns the parsed object.

For example:

Comment thread doc/api/tls.md Outdated

@refack refack Jul 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will return —

@cjihrig

cjihrig commented Jul 12, 2017

Copy link
Copy Markdown
Contributor

See @bnoordhuis comment: #14193 (comment)

@refack refack added the blocked PRs that are blocked by other issues or PRs. label Jul 12, 2017
@refack

refack commented Jul 12, 2017

Copy link
Copy Markdown
Contributor

Blocked till deprecation is decided

@XadillaX XadillaX changed the base branch from master to v8.x-staging July 13, 2017 07:19
@XadillaX XadillaX force-pushed the doc/tls.parseCertString branch from d0b39da to d61d561 Compare July 13, 2017 07:42

@refack refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
awaiting deprecation decision

@XadillaX

Copy link
Copy Markdown
Contributor Author

@refack I've created another PR to move the function. #14218

@cjihrig

cjihrig commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

@XadillaX can this PR be closed?

@XadillaX

Copy link
Copy Markdown
Contributor Author

@cjihrig sure

@cjihrig cjihrig closed this Jul 13, 2017
@refack

refack commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

Superseded by #14218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants