Skip to content

CloudStack Backup & Recovery Framework#3553

Merged
DaanHoogland merged 102 commits into
apache:masterfrom
shapeblue:bckuprecframework
Mar 3, 2020
Merged

CloudStack Backup & Recovery Framework#3553
DaanHoogland merged 102 commits into
apache:masterfrom
shapeblue:bckuprecframework

Conversation

@yadvr

@yadvr yadvr commented Aug 13, 2019

Copy link
Copy Markdown
Member

This framework provides CloudStack users the ability to backup their guest VMs for recovery purposes, in case they suffer a hardware or software issue with their instances or the underlying infrastructure. This framework allows CloudStack to be integrated with Backup and Recovery providers, as pluggable solutions. Each provider should implement the backup and recovery methods provided by the framework in their own way.

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Backup+and+Recovery+Framework
Doc: apache/cloudstack-documentation#85
Primate/UI: apache/cloudstack-primate#64

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@svenvogel

Copy link
Copy Markdown
Contributor

@rhtyd small questions. which provider does this mean? Veeam?

@yadvr

yadvr commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

@svenvogel yes Veeam is a supported provider plugin

@DaanHoogland DaanHoogland reopened this Nov 7, 2019
@yadvr yadvr self-assigned this Nov 19, 2019
@yadvr yadvr force-pushed the bckuprecframework branch 2 times, most recently from 50d084f to 0c1969a Compare November 19, 2019 09:41
This introduces a new framework that provides CloudStack users the
ability to backup their guest VMs for recovery purposes, in case they
suffer a hardware or software issue with their instances or the
underlying infrastructure. This framework allows CloudStack to be
integrated with Backup and Recovery providers, as pluggable solutions.
Each provider must implement the backup and recovery methods provided by
the framework in their own way. Two B&R plugins ship with this change:

  - Veeam B&R: for VMware
  - Dummy: for testing purposes

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Backup+and+Recovery+Framework

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr force-pushed the bckuprecframework branch from 68ac065 to b75f35e Compare November 20, 2019 08:00
yadvr added 14 commits November 20, 2019 13:50
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-950

@yadvr

yadvr commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-956

@yadvr

yadvr commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan test centos7 vmware-65u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd unsupported parameters provided. Supported mgmt server os are: centos6, centos7, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1

@yadvr

yadvr commented Feb 26, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1129)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3553-t1129-kvm-centos7.zip
Smoke tests completed. 81 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1135)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36067 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3553-t1135-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 xenserver-71

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1141)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29948 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3553-t1141-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 79 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_nic Error 69.54 test_nic.py
test_01_scale_vm Failure 19.63 test_scale_vm.py

@yadvr

yadvr commented Feb 28, 2020

Copy link
Copy Markdown
Member Author

I see a new nic related error but I'm not sure it's due to B&R changes cc @DaanHoogland I'll kick test again
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-968

@yadvr

yadvr commented Feb 28, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan test centos7 xenserver-71

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1145)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31922 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3553-t1145-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_scale_vm Failure 18.52 test_scale_vm.py

@DaanHoogland

Copy link
Copy Markdown
Contributor

i saw the nic error in #3847 (comment) as well, and it passed just now. I think we are good to merge, @PaulAngus ?

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm (even when this big)
Tested extensively as admin and normal user from UI and with API.
caveat: basic zones not tested because of #3031

@abh1sar abh1sar mentioned this pull request Jul 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants